-
Notifications
You must be signed in to change notification settings - Fork 191
Revert change in a75b53 to make ValidRemotes private #73
Conversation
This constant was in use by code using libcompose Signed-off-by: Darren Shepherd <darren@rancher.com>
Could we expose a better interface than a list of constants? Why does the code need to know about this? |
@dnephin Hmmm... The reason the code is here is that you can build from any valid Docker remote location, https://docs.docker.com/reference/api/docker_remote_api_v1.20/#build-image-from-a-dockerfile Looking at the Docker compose docs doesn't seem like this is possible. Is there a specific reason you aren't allowed to do a Docker build from a remote location? By remote I mean the definition of the |
No reason, there's an PR to add that support (that needs more work), but I don't know if anyone is actively working on it. There's been very little demand for it, so it hasn't been a priority. |
Sorry, my earlier question was, why does code external to libcompose need this constant |
@dnephin The reason why is that you can supply a custom Builder. So currently we use libcompose in a server side context. In that context we don't want to allow builds that reference the disk. So we only allow remote builds if libcompose is ran in a server side context. |
@ibuildthecloud Using it on rancher-compose right ? I'm wondering something though, should it be there (in |
In docker/docker would be preferred and that is where I copied the list to begin with. Let me look from where. I imagine it was private. |
@ibuildthecloud @dnephin I think we should fill an issue for make this better and merge this one as it breaks current codes, wdyt ? (the actual list feels weird at it would mean @ibuildthecloud isn't it in |
Ya, I'm ok merging this, it shouldn't hurt anything |
Created #95, so LGTM 🐺 |
Revert change in a75b53 to make ValidRemotes private
This constant was in use by code using libcompose
Signed-off-by: Darren Shepherd darren@rancher.com